fix(sandbox): serialize sandboxed job error #2813
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change preserves the original error when throwing from a sandboxed job with a circular reference or I think a function in the object.
The TypeError is reproducible with worker threads off and a simple circular reference:
The DataCloneError occurs with axios errors and
useWorkerThreads: true
, see this branch:Initially attempted to check the value type ignoring "function" and serializing only "object", but using the stringify/parse method on the whole object seems more consistent and fixed all cases.