Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sandbox): fix serialization of error with circular references are present #2815

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Oct 10, 2024

ref #2813

@@ -212,14 +212,28 @@ export const parseObjectValues = (obj: {
return accumulator;
};

const getCircularReplacer = (rootReference: any) => {
const references = new WeakSet();
references.add(rootReference);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to pass the root reference as error object is not the same as value

Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roggervalf roggervalf force-pushed the fix-sandbox-circular-reference branch from e314031 to 92f7f89 Compare October 12, 2024 14:08
@roggervalf roggervalf changed the title fix(sandbox): fix serialization of error with circular references fix(sandbox): fix serialization of error with circular references are present Oct 12, 2024
@roggervalf roggervalf merged commit a384d92 into master Oct 12, 2024
10 of 11 checks passed
@roggervalf roggervalf deleted the fix-sandbox-circular-reference branch October 12, 2024 14:16
github-actions bot pushed a commit that referenced this pull request Oct 12, 2024
## [5.19.1](v5.19.0...v5.19.1) (2024-10-12)

### Bug Fixes

* **sandbox:** fix serialization of error with circular references are present ([#2815](#2815)) fix [#2813](#2813) ([a384d92](a384d92))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants