feat(queue): add queue version support #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
reviewed
Oct 12, 2024
src/classes/scripts.ts
Outdated
| @@ -220,7 +225,7 @@ export class Scripts { | |||
| } | |||
|
|
|||
| if (<number>result < 0) { | |||
| throw this.finishedErrors({ | |||
| throw finishedErrors({ | |||
There was a problem hiding this comment.
finishedErrors metros is part of scripts class to have a way to override it in pro version without having to to rewrite places where is calles. If it's outside of script, new version of finishedErrors need to be passed in all places where new pro errors need to be handled
roggervalf
force-pushed
the
feat/add-queue-version-support
branch
from
72d4896
to
a4b32c9
Compare
roggervalf
approved these changes
Oct 13, 2024
src/utils.ts
Outdated
| @@ -10,6 +10,10 @@ import { ChildMessage, RedisClient } from './interfaces'; | |||
| import { EventEmitter } from 'events'; | |||
| import * as semver from 'semver'; | |||
|
|
|||
| import { ErrorCode } from './enums'; | |||
There was a problem hiding this comment.
Looks like this reference is not used anymore
…askforcesh/bullmq into feat/add-queue-version-support
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2024
# [5.20.0](v5.19.1...v5.20.0) (2024-10-13) ### Features * **queue:** add queue version support ([#2822](#2822)) ([3a4781b](3a4781b))
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Oct 14, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.19.1` -> `5.20.0`](https://renovatebot.com/diffs/npm/bullmq/5.19.1/5.20.0) | --- ### Release Notes <details> <summary>taskforcesh/bullmq (bullmq)</summary> ### [`v5.20.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.20.0) [Compare Source](taskforcesh/bullmq@v5.19.1...v5.20.0) ##### Features - **queue:** add queue version support ([#​2822](taskforcesh/bullmq#2822)) ([3a4781b](taskforcesh/bullmq@3a4781b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjAuMCIsInVwZGF0ZWRJblZlciI6IjM4LjEyMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/220 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.