Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flows): add telemetry support #2879

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

manast
Copy link
Contributor

@manast manast commented Nov 4, 2024

Fixes #2872

@manast manast requested a review from fgozdz November 4, 2024 19:41
Copy link
Contributor

@fgozdz fgozdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe we should also observe close method like in the queue and worker classes

@manast
Copy link
Contributor Author

manast commented Nov 5, 2024

LGTM but maybe we should also observe close method like in the queue and worker classes

Yes, but I think BullMQ users will tell which ones are the important ones to wrap.

@manast manast merged commit 5ed154b into master Nov 5, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
# [5.24.0](v5.23.1...v5.24.0) (2024-11-05)

### Features

* **flows:** add telemetry support ([#2879](#2879)) ([5ed154b](5ed154b))
@manast manast deleted the feat/add-telemetry-support-for-flows branch November 5, 2024 14:08
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Nov 6, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.23.1` -> `5.25.0`](https://renovatebot.com/diffs/npm/bullmq/5.23.1/5.25.0) |

---

### Release Notes

<details>
<summary>taskforcesh/bullmq (bullmq)</summary>

### [`v5.25.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.25.0)

[Compare Source](taskforcesh/bullmq@v5.24.0...v5.25.0)

##### Features

-   **queue-events:** add QueueEventsProducer for publishing custom events ([#&#8203;2844](taskforcesh/bullmq#2844)) ([5eb03cd](taskforcesh/bullmq@5eb03cd))

### [`v5.24.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.24.0)

[Compare Source](taskforcesh/bullmq@v5.23.1...v5.24.0)

##### Features

-   **flows:** add telemetry support ([#&#8203;2879](taskforcesh/bullmq#2879)) ([5ed154b](taskforcesh/bullmq@5ed154b))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/298
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add telemetry support for flow
2 participants