-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flows): add telemetry support #2879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgozdz
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but maybe we should also observe close method like in the queue and worker classes
Yes, but I think BullMQ users will tell which ones are the important ones to wrap. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
# [5.24.0](v5.23.1...v5.24.0) (2024-11-05) ### Features * **flows:** add telemetry support ([#2879](#2879)) ([5ed154b](5ed154b))
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Nov 6, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.23.1` -> `5.25.0`](https://renovatebot.com/diffs/npm/bullmq/5.23.1/5.25.0) | --- ### Release Notes <details> <summary>taskforcesh/bullmq (bullmq)</summary> ### [`v5.25.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.25.0) [Compare Source](taskforcesh/bullmq@v5.24.0...v5.25.0) ##### Features - **queue-events:** add QueueEventsProducer for publishing custom events ([#​2844](taskforcesh/bullmq#2844)) ([5eb03cd](taskforcesh/bullmq@5eb03cd)) ### [`v5.24.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.24.0) [Compare Source](taskforcesh/bullmq@v5.23.1...v5.24.0) ##### Features - **flows:** add telemetry support ([#​2879](taskforcesh/bullmq#2879)) ([5ed154b](taskforcesh/bullmq@5ed154b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/298 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2872