Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling for some non-image placeholders is broken after the CSS aspect-ratio was removed #35

Open
anton-karlovskiy opened this issue Feb 3, 2021 · 1 comment
Open

Styling for some non-image placeholders is broken after the CSS aspect-ratio was removed #35

anton-karlovskiy opened this issue Feb 3, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@anton-karlovskiy
Copy link
Member

anton-karlovskiy commented Feb 3, 2021 •
edited
Loading

explore-all
non-credit
none-movie-info

This is because the non-image placeholders were using the CSS aspect-ratio styling so after removing the CSS aspect-ratio, they were broken.
I have not fixed this issue yet and just add some comments named TODO: should add styling for span element.

cc @addyosmani
@anton-karlovskiy anton-karlovskiy added the bug Something isn't working label Feb 3, 2021
@anton-karlovskiy anton-karlovskiy mentioned this issue Feb 3, 2021
Merged
@anton-karlovskiy
Copy link
Member Author

FYI: I'm just logging: we should check this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anton-karlovskiy