Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember to 1.3 and latest Ember-data #704

Closed
sindresorhus opened this issue Oct 30, 2013 · 2 comments
Closed

Update Ember to 1.3 and latest Ember-data #704

sindresorhus opened this issue Oct 30, 2013 · 2 comments

Comments

@sindresorhus
Copy link
Member

Followup to #670

Some things that needs to be fixed:

  • The textbox for entering new todos isn't focused on load
  • The text shouldn't be selected when entering editingmode

Notes from author:

  • Uses debounce to ensure we only send one removeTodo action for consecutive focus-out and insert-newline events (fixes an error that ember-data otherwise would raise)
  • Use bufferedTitle property in TodoController so that we can rollback changes to the todo on pressing 'escape'. (Required by spec)
  • Does not use rollback() because it is not supported in ember-data beta 1 (and local storage adapter is not compatible with ember-data beta 2)

// @bantic

@sindresorhus
Copy link
Member Author

@bantic @mixonic @trek do you know anyone that could be interested in getting the ember app up to date?

@bantic
Copy link
Contributor

bantic commented Feb 2, 2014

I will take a crack at this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants