Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .focus() instead of .select()? #203

Closed
sindresorhus opened this issue Jul 1, 2012 · 9 comments
Closed

Use .focus() instead of .select()? #203

sindresorhus opened this issue Jul 1, 2012 · 9 comments

Comments

@sindresorhus
Copy link
Member

I can't remember why we started using .select() in the first place, but @IgorMinar has a point:

because when I doubleclick on a item I typically want to change only a small part of it. select() highlights the whole text and forces me to deselect it. if I do want to select the whole thing I can just triple click on the item and then I'll get this behavior.

I think we should change it back.

@addyosmani
Copy link
Member

+1 on changing.
On Jul 1, 2012 3:11 PM, "Sindre Sorhus" <
reply@reply.github.com>
wrote:

I can't remember why we started using .select() in the first place, but
@IgorMinar has a point:

because when I doubleclick on a item I typically want to change only a
small part of it. select() highlights the whole text and forces me to
deselect it. if I do want to select the whole thing I can just triple click
on the item and then I'll get this behavior.

I think we should change it back.


Reply to this email directly or view it on GitHub:
#203

sindresorhus added a commit that referenced this issue Aug 3, 2012
@sindresorhus
Copy link
Member Author

Converted all apps to use .focus, but even so, there are some that still selects the text. Need to figure out why...

The following still selects the text:

  • Dojo
  • Emberjs
  • Spine
  • YUI
  • Backbone Require
  • Knockout Require
  • Stapes
  • Stapes Require
  • Epitome
  • Soma.js
  • Backbone Marionette

Edited by arthurvr to remove deleted apps.

@sindresorhus
Copy link
Member Author

@jsoverson just pinging you incase you would be interested in tackling any of these :)

@passy
Copy link
Member

passy commented Mar 9, 2013

Is the list still up to date?

@sindresorhus
Copy link
Member Author

@passy partly. those apps is not fixed, but there has been included additional apps since then that might have the same issue.

@arthurvr
Copy link
Member

Emberjs

Seems to be working correctly for me. Can you confirm that, @sindresorhus?

@arthurvr
Copy link
Member

arthurvr commented Jun 7, 2015

Ticked ember, then.

@samccone samccone modified the milestones: 1.4, 1.2 Jul 13, 2015
@arthurvr
Copy link
Member

I never noticed it back then, but since when I ticked the ember app and removed the dropped apps, this can be closed :) Yay!

@sindresorhus
Copy link
Member Author

🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants