-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use .focus() instead of .select()? #203
Comments
+1 on changing.
|
Converted all apps to use .focus, but even so, there are some that still selects the text. Need to figure out why... The following still selects the text:
Edited by arthurvr to remove deleted apps. |
@jsoverson just pinging you incase you would be interested in tackling any of these :) |
Is the list still up to date? |
@passy partly. those apps is not fixed, but there has been included additional apps since then that might have the same issue. |
Seems to be working correctly for me. Can you confirm that, @sindresorhus? |
Ticked ember, then. |
I never noticed it back then, but since when I ticked the ember app and removed the dropped apps, this can be closed :) Yay! |
🎉🎉🎉 |
I can't remember why we started using .select() in the first place, but @IgorMinar has a point:
I think we should change it back.
The text was updated successfully, but these errors were encountered: