Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should spaces be converted? #301

Closed
btea opened this issue Jan 17, 2023 · 5 comments
Closed

Should spaces be converted? #301

btea opened this issue Jan 17, 2023 · 5 comments

Comments

@btea
Copy link
Contributor

btea commented Jan 17, 2023

If the initialized project name contains spaces, should it be converted, such as replaced with -.

@amrbashir
Copy link
Member

yeah, it gets replaced with -, did it not get replaced for you? if not, let me know the steps to reproduce.

@amrbashir amrbashir closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2023
@btea
Copy link
Contributor Author

btea commented Jan 18, 2023

image

@amrbashir
Copy link
Member

You can see in the second question it got converted to -.

@btea
Copy link
Contributor Author

btea commented Jan 19, 2023

Yes, the Package name were converted, but the project name spaces were not. As shown in the screenshot, running cd tauri test after the initialization is complete will fail. Therefore, I am wondering whether it is necessary to convert the spaces in the project name to -.

@amrbashir
Copy link
Member

amrbashir commented Jan 19, 2023

Ah I see what you mean, and I actually released a version today https://github.com/tauri-apps/create-tauri-app/releases/tag/create-tauri-app-v2.7.7 with a fix for that specifically. It will wrap the path in quotes if it contains spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants