fix: the system theme obtained is always light (#1091)

1111mp · lucasfernog · web-flow · commit dd9251a8f0a9 · 2025-03-07T07:39:51.000-03:00
* fix(macos): the system theme obtained is always light (tauri-apps/tauri#12894) Signed-off-by: The1111mp <The1111mp@outlook.com> * add change file --------- Signed-off-by: The1111mp <The1111mp@outlook.com> Co-authored-by: Lucas Nogueira <lucas@tauri.app>
diff --git a/.changes/fix-macos-theme.md b/.changes/fix-macos-theme.md
@@ -0,0 +1,5 @@
+---
+"tao": patch
+---
+
+Fix `Window::theme()` always returning `Theme::Light` and `WindowEvent::ThemeChanged()` not delivered on macOS.
diff --git a/src/platform_impl/macos/window.rs b/src/platform_impl/macos/window.rs
@@ -332,7 +332,7 @@ pub(super) fn get_ns_theme() -> Theme {
     let app_class = class!(NSApplication);
     let app: id = msg_send![app_class, sharedApplication];
     let has_theme: bool = msg_send![app, respondsToSelector: sel!(effectiveAppearance)];
-    if has_theme {
+    if !has_theme {
       return Theme::Light;
     }
     let appearance: id = msg_send![app, effectiveAppearance];

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"tao": patch
 +---
++
 +Fix `Window::theme()` always returning `Theme::Light` and `WindowEvent::ThemeChanged()` not delivered on macOS.
Original file line number	Diff line number	Diff line change
`@@ -332,7 +332,7 @@ pub(super) fn get_ns_theme() -> Theme {`
`332`	`332`	`let app_class = class!(NSApplication);`
`333`	`333`	`let app: id = msg_send![app_class, sharedApplication];`
`334`	`334`	`let has_theme: bool = msg_send![app, respondsToSelector: sel!(effectiveAppearance)];`
`335`		`- if has_theme {`
	`335`	`+ if !has_theme {`
`336`	`336`	`return Theme::Light;`
`337`	`337`	`}`
`338`	`338`	`let appearance: id = msg_send![app, effectiveAppearance];`