Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code with new Art Mode API #675

Open
CGDaveMac opened this issue Apr 13, 2024 · 14 comments
Open

Update code with new Art Mode API #675

CGDaveMac opened this issue Apr 13, 2024 · 14 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@CGDaveMac
Copy link

          With firmware 1622, the art WebSocket api is back! Looks like some calls may need to be renamed. And you can check ArtMode status!

https://www.reddit.com/r/TheFrame/comments/1c2lgbs/art_mode_api_is_back/

Originally posted by @CGDaveMac in #519 (comment)

@fjwillemsen
Copy link

Is anyone working on implementing it? I'm not (yet) familiar with the homebridge-samsung-tizen codebase, not sure how and where to change things to implement this. Would be very grateful to anyone that does or can give pointers so I can do it!

@tavicu
Copy link
Owner

tavicu commented Apr 28, 2024

Right now I'm working on rewriting the plugin from scratch changing almost everything, but the most important change for the user is how the state of TV is detected.

I found a way that at the moment I could say it's 99% reliable :)

It was very hard advancing with the development since we had a new member in the family and my time was very limited.

Once I have all the base functionality I will order a Frame TV and check the "new" api and what allows us to do.

I will keep this issue open and update on the status as soon as I'll have one.

Starting to develop something right now it will be a waste of time since it will not be merged unless is something critical.

@tavicu tavicu self-assigned this Apr 28, 2024
@tavicu tavicu added the enhancement New feature or request label Apr 28, 2024
@tavicu tavicu added this to the ESM Version 6 milestone Apr 28, 2024
@fjwillemsen
Copy link

@tavicu Fantastic work, I'm very much looking forward to it! And congrats on the young one 😄 If you want I can help you test it, I have a Frame TV. Do you have a timeline / estimated release date?

@tavicu
Copy link
Owner

tavicu commented Apr 28, 2024

Thank you!

At the moment I don't have a timeline. Tomorrow I'll start the "engine" again and I will dedicate more time to this.
There are some things that I still try to decide which will be the best approach so I can maintain backwards compatibility and also implement the new approach.

I will get back on this at the end of next week.

Once I will have a version ready for testing I will release it as beta and for sure I will need all the help with testing :P. Having a Frame will be a plus too, since there are not many users with Frame out there

@AdmiralMichael
Copy link

Just a question, so I have a pre 2022 TV and this plugin works sometimes. It's still the best method though.

Anyways my question is would this new API and/or rewriting it improve the reliability for the older TVs?

@tavicu
Copy link
Owner

tavicu commented May 15, 2024

Anyways my question is would this new API and/or rewriting it improve the reliability for the older TVs?

Yes, it will be compatible with all TVs that are currently supported

@jamesbull
Copy link

Another Frame user (2023) here! Happy to test for ya!

@joe-tofu
Copy link

And another Frame user – 2023 model as well – happy to be a test pilot here.

@ufkel
Copy link

ufkel commented May 26, 2024

I can bring a 2022 Frame to the test table. Happy to help.

@Foxfire0
Copy link

If it helps I can test new code on 2024 frame.

@dredgy
Copy link

dredgy commented Jun 22, 2024

Happy to provide funding as well as testing 🙃

@Cristov9000
Copy link

I have a 2021 Frame and 2023 Frame. Happy to test any new code!

@raphtabe
Copy link

raphtabe commented Oct 7, 2024

Hello !
Thanks for the work !
Is there anupdate 6 months later ?
I have a 2024 model available for testing 🙂

@raphtabe
Copy link

raphtabe commented Oct 7, 2024

(found my answer here: #696 (comment))
work is ongoing 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests