Resolve() crashes on whitespace in params bracket

[khaliddermoumi]

When there's a blank in a uri template string, the Resolve()-method crashes.

Meaning:

• this template will work: "/feeds/events{?fromId}"
• this template will crash when "Resolve()" is called: "/feeds/events{? fromId}"

I believe the UriTemplates implementation should either moan when constructed with such a template: "/feeds/events{? fromId}", or work correctly. But throwing an exception when "Resolve()" is called is too late.

[darrelmiller]

I looked into this and I don't have an ideal answer for you. Technically the spec does not allow whitespace where you have it, so by the letter of the law, it is not a valid template.
However, I don't process the template until you actually call resolve, so the error is only detected during processing. In theory I could add in a redundant call to resolve in the constructor, but then everyone pays the price of that extra resolve call.

If you need to know that a template is valid at construction time, then you could call Resolve() immediately after creating the template. There is no harm in calling Resolve() multiple times. Another possibility is to add a Verify() method that returns an error message if it finds anything. That would avoid having to do try catch blocks around the Resolve check.

Thoughts?

[khaliddermoumi]

Ok, this is not a very critical issue, and your proposals make sense.

On the other side, it is a kind of convention that patterns such as URIs get validated at construction time.
Examples:

• System.Uri constructor throws UriFormatException
• java.net.URI constructor throws URISyntaxException

I think this behaviour makes sense. I personally would stick to it, I would make the constructor perform a validation.