Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related cards and game mechanic tokens #272

Open
pyyhttu opened this issue Sep 23, 2023 · 9 comments
Open

Related cards and game mechanic tokens #272

pyyhttu opened this issue Sep 23, 2023 · 9 comments

Comments

@pyyhttu
Copy link

pyyhttu commented Sep 23, 2023

Noticed I need to constantly refer to "game mechanic tokens" as an additional assistance with cards like Birthday Escape and White Plume Adventurer.

That said, could The Ring emblem be added and link every "the ring tempts you" card to that under the "Related cards" section, (à la City in a Bottle being a prime example)?

@taw
Copy link
Owner

taw commented Sep 23, 2023

Oh right, I was planning to add The Ring, just like I added dungeons, I just never got to it.

@taw
Copy link
Owner

taw commented Sep 24, 2023

I added "The Ring", "The Ring Tempts You", "The Initiative" and is:token / is:card queries.

There's a bunch of things missing - like "The Monarch", and all the related cards links for each of them.

@taw
Copy link
Owner

taw commented Sep 25, 2023

These have correct related links:

  • The Ring / The Ring Tempts You
  • The Initiative / Undercity

Dungeons and The Monarch still todo.

@taw
Copy link
Owner

taw commented Oct 15, 2023

Related for Dungeons work too now.

I'm still thinking about adding The Monarch and Day / Night tokens.

@pyyhttu
Copy link
Author

pyyhttu commented Oct 15, 2023

Related for Dungeons work too now.

Hmm... I did https://mtg.wtf/card?q=o%3A%22venture+into+the+dungeon%22 and started to check, and found from that list at least that,

Doesn't have any of the three dungeons marked as related:

Has the three related dungeons, but also Undercity marked as related which a card shouldn't have because can't venture to Undercity with regular "venture into the dungeon":

@taw
Copy link
Owner

taw commented Oct 15, 2023

The first part is a bug, as I had that regexp to match lower case only.

The second part is because "As long as you've completed a dungeon" technically counts Undercity as well, so I made it match all dungeons. It's pretty borderline.

@taw
Copy link
Owner

taw commented Oct 15, 2023

I fixed the first issue. Does everything look good now?

@pyyhttu
Copy link
Author

pyyhttu commented Oct 18, 2023

Yes, the first part is fixed.

The second part is indeed borderline. My brain didn't even register the technicality "completed a dungeon" would include Undercity as well, which it does!

However, I think from usability perspective having Dungeon cards related only to "Venture into dungeon" cards is the better call, as is having "Initiative" cards related only to Undercity. I fear mixing them as related cards may now throw some people off (Wait a minute, I can venture into Undercity with this?).

Additionally, I feel majority of the search cases for "venture into dungeon" involves users wanting to find just those cards, along seeing it helpful to see only the actual Dungeons as related cards they can venture with them to.

@axxroytovu
Copy link
Contributor

I think I agree with pyyhttu. The comprehensive rules do spell out that the Undercity is mechanically different than the other three dungeons, even though they do interact with each other.

205.3p One dungeon card (Undercity) has a subtype; this subtype is called a dungeon type. That dungeon type is Undercity.

701.46d Venture into [quality] is a variant of venture into the dungeon. If a player is instructed to “venture into [quality]” while they don’t own a dungeon card in the command zone, they choose a dungeon card they own from outside the game with the indicated quality and put it into the command zone. They put their venture marker on the topmost room of that dungeon. If they already own a dungeon card in the command zone, they follow the normal procedure for venturing into the dungeon outlined in 701.46b–c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants