-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sealed Support #82
Comments
I haven't looked at your code so I apologize if you know some of this already, but here are some notes that I've made over time regarding booster pack layout:
Also, I really like the idea of |
I left those complex sets for last (14 still to do).
I didn't add any sets with DFC sheet yet. ISD/DKA has one slot for DFCs, with unknown rarity ratio. SOI/EMN has two different DFC slots, not sure how that works.
Not currently implemented, but on todo list for Unstable etc.
That was only in one print run, and there's no real data, so I'll just drop this completely.
Not implemented yet.
Already done.
I googled countless claims about it, and picked some plausible numbers that do that. I'm pretty sure they're not very accurate. There's photos of foil sheet with the usual 2 copies of each rare / 1 copy of each mythic, and total foil drop rate is printed on each pack, but rare:uncommon:common:basic ratio is unknown.
Totally forgot about this one, will do.
Already done. Foil rarities petty much guessed.
|
In all packs, one of the common slots is replaced with a common or uncommon DFC. In 1 out of 8 packs, a second common slot is replaced with a rare or mythic DFC. Oh, and one thing I forgot:
|
I completely skipped the "checklist replaces basic" part since we don't have checklists, tokens, marketing cards etc., and it makes no difference to Limited experience anyway. Maybe something to consider much later. |
That makes sense, especially since I'm now finding conflicting info about whether DKA had checklists in the basic or marketing slot. |
Do you have any source on that 4320 God Pack frequency? And these are not foils, right? I put it in, but number of unsourced assumptions I'm making, especially about foils, is really high. |
I wrote down this Reddit comment as the source. It's just the word of one single person who claims to work at an LGS but I haven't found any other numbers with better sources. |
Well, exact God Pack ratio doesn't affect things much. So the backend is quite close to done (8 sets left, of course the 8 most complex ones), leaving just two big problems:
I'll put some simple frontend for that. Proper Sealed simulator / deck builder could get really advanced, but it's probably fine to just do something real basic for now. |
I'm not sure I buy the idea of 2 DFC sheets for SOI. That would be 15 card sheet for rares/mythics (3+62), and presumably 28 or 32 card sheet (20+42 or 20+4*3) for commons/uncommons. These are really weird sizes. WotC officially only says is that there's "as-fan of about 1.125". Wiki says it replaces common. There's probably something really weird going on here. Of course it's totally fine for us to just use an approximation for now (or forever, those issues rare get resolved). |
Very simple Sealed is now online, right now it just prints unformatted list of cards, so obviously needs some sort of real UI. There's still a bunch of backend issues (Conspiracy sets, Unstable, and Battlebond not supported; Dominaria guaranteed legend per pack not implemented; alt art not balanced properly etc.), and backend performance is a bit weak. I'd say backend is about 90% ready. |
Now displays cards, even does foil effect. I'm a bit lost what kind of interface would be best here. Something like MTGO Limited deck builder? Something completely different? If anyone wants to open custom packs on loreseeker, |
Not familiar with MTGO but maybe this could be integrated with the decklist feature somehow? I've already implemented pack generation logic for the custom sets, will pull now and see how well it works. |
I could make Sealed pools use current decklist viewer for now. I don't think it would be that great. As for decklist viewer, the one saffron olive uses is so pretty I really want to give it a try, not sure how functional it would be really. |
According to maro's podcast (Dominaria part 3), Dominaria packs don't have guaranteed legendary, they have guaranteed legendary creature specifically. That makes numbers work a lot better as there:
That's somewhat more sensible than previous 63/58/22/58 numbers - at least for uncommons. I still need to do a bit of math to make sure it works with this sheet model. So "Legendary Enchantment - Aura" does not count. I wonder if there's a way to make rare/mythic sheet work a bit better? |
So "legend" here means "legendary creature", "normal" means everything else. Dominaria packs can have 8 kinds - 0-3 legend uncommons, times 0-1 legend rares. There are four hard constraints:
I did the math, and implemented the simplest possible model, where packs with multiple legend uncommons never happen. That yields just one combination of weights. That's not ideal, as in fully random model 9/64 packs would have two legend uncommons, and 1/64 would have three. I suspect Wizards collation would try to avoid that. Anyone knows (video evidence or something) if multiple uncommon legend packs are a thing? Or if my assumptions are wrong? |
BFZ packs should only contain full-art basics. Similarly, OGW packs should only contain full-art Wastes. |
Right, so adding to the checklist:
So many things to do before even getting to the UI. |
All these are now excluded from Sealed |
After watching too many box opening videos, it's clear that in CNS foil draft-matters card go into draft-matters slot, not regular foil slot. |
Closing as all issues moved to #106 |
There's an obvious feature which is currently missing, that is any concept of packs. I added partial support for it, so you can use scripts like:
./bin/open_packs 6xM11
- open 6 packs of Magic 11./bin/open_packs NPH MBS SOM
- open one pack each from Scars of Mirrodin block./bin/open_packs --list
- list currently supported packs./bin/open_packs --unsupported
- list of unsupported packsRight now it supports 117/120 sets with packs (3 to go), unfortunately missing a lot of the new ones.
Final missing sets:
Other:
is:front
is:back
/is:primary
is:secondary
queries. They differ as aftermath/flip is front secondary. DFC is back secondary. Split and normal cards are front primary.PhysicalCard
, right now it just gives left side of split card etc., won't tell you which card is foil - it will be useful for constructed decks as wellis:booster
part of the indexer, and the engineis:booster
- card is in booster product, and not one of the extras (like planeswalker deck, orFiresong and Sunspeaker)
CardSheet
full ofPhysicalCard
objects to encapsulate some of that stuffCardSheet
CardSheet#probability(card)
Pack
needs same recursive structure asCardSheet
, and#probability(list_of_cards)
is:draft
support (it happens to correspond with CNS sheet)Nice to haves:
is:foil
/is:nonfoil
- sort of incidental, but Sealed simulator forces getting this information, so might as well expose it. A card can match both (like M10 Lightning Bolt is available both foil and nonfoil, as is vast majority of cards), so these names are a it awkwardWe don't have exact foil distribution information, stuff like 101st uncommon
Some sources:
Probably unfixable issues:
The text was updated successfully, but these errors were encountered: