Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action fails if there no python files modified #6

Closed
valentijnscholten opened this issue Sep 26, 2020 · 1 comment
Closed

action fails if there no python files modified #6

valentijnscholten opened this issue Sep 26, 2020 · 1 comment

Comments

@valentijnscholten
Copy link

When a PR has only changes in non-python fails, the flake8-your-pr results in a failure because it gets an empty value for new_files_in_branch, or maybe the piped sequence of commands fails.

https://github.com/valentijnscholten/django-DefectDojo/pull/5/checks?check_run_id=1170299683

This leads to the check being marked as failure preventing the PR from being merged.
@valentijnscholten
Copy link
Author

github created it twice after a 404...

@valentijnscholten valentijnscholten mentioned this issue Sep 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@valentijnscholten