Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code improvements #20

Open
3 tasks
tbeason opened this issue Nov 19, 2020 · 0 comments
Open
3 tasks

code improvements #20

tbeason opened this issue Nov 19, 2020 · 0 comments

Comments

@tbeason
Copy link
Owner

tbeason commented Nov 19, 2020 •
edited
Loading

Glancing over the code again, I see some potential updates.

  • No need to require DataFrames.jl when I could just use Tables.jl. A standard column table will probably suffice, and the docs can just recommend conversion to DataFrame if that is what is desired.

  • Interpolation should be cleaned up.

  • There are other data sources that might be better options given the annoying XML nature of the original source. https://www.financialresearch.gov/ is one alternative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbeason