Skip to content

Commit 1acefd8

Browse files
committed
Fix: Do not resend fetch limit request if the last one failed
Due to side effects it is possible that the inverter receives the request but the DTU does not receive the answer. In this case the DTU would resend the request but the inverter would generate a event log entry (DTU command failed) because it received the message twice.
1 parent ec9af88 commit 1acefd8

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

lib/Hoymiles/src/Hoymiles.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ void HoymilesClass::loop()
6464
iv->sendAlarmLogRequest(force);
6565

6666
// Fetch limit
67-
if ((iv->SystemConfigPara()->getLastLimitRequestSuccess() == CMD_NOK)
68-
|| ((millis() - iv->SystemConfigPara()->getLastUpdateRequest() > HOY_SYSTEM_CONFIG_PARA_POLL_INTERVAL)
67+
if (((millis() - iv->SystemConfigPara()->getLastUpdateRequest() > HOY_SYSTEM_CONFIG_PARA_POLL_INTERVAL)
6968
&& (millis() - iv->SystemConfigPara()->getLastUpdateCommand() > HOY_SYSTEM_CONFIG_PARA_POLL_MIN_DURATION))) {
7069
_messageOutput->println("Request SystemConfigPara");
7170
iv->sendSystemConfigParaRequest();

0 commit comments

Comments
 (0)