Fix: Do not resend fetch limit request if the last one failed

Due to side effects it is possible that the inverter receives the request but the DTU does not receive the answer. In this case the DTU would resend the request but the inverter would generate a event log entry (DTU command failed) because it received the message twice.
tbnobody · Sep 5, 2023 · 1acefd8 · 1acefd8
1 parent ec9af88
commit 1acefd8
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/Hoymiles/src/Hoymiles.cpp b/lib/Hoymiles/src/Hoymiles.cpp
@@ -64,8 +64,7 @@ void HoymilesClass::loop()
                 iv->sendAlarmLogRequest(force);
 
                 // Fetch limit
-                if ((iv->SystemConfigPara()->getLastLimitRequestSuccess() == CMD_NOK)
-                    || ((millis() - iv->SystemConfigPara()->getLastUpdateRequest() > HOY_SYSTEM_CONFIG_PARA_POLL_INTERVAL)
+                if (((millis() - iv->SystemConfigPara()->getLastUpdateRequest() > HOY_SYSTEM_CONFIG_PARA_POLL_INTERVAL)
                         && (millis() - iv->SystemConfigPara()->getLastUpdateCommand() > HOY_SYSTEM_CONFIG_PARA_POLL_MIN_DURATION))) {
                     _messageOutput->println("Request SystemConfigPara");
                     iv->sendSystemConfigParaRequest();