refactor($compile): rename directive.type to directive.templateNamespace

BREAKING CHANGE (within 1.3.0-beta): `directive.type` was renamed to `directive.templateNamespace`

The property name `type` was too general.

Author: tbosch

src/ng/compile.js

@@ -219,18 +219,17 @@
  * * `M` - Comment: `<!-- directive: my-directive exp -->`
  *
  *
- * #### `type`
- * String representing the document type used by the markup. This is useful for templates where the root
- * node is non-HTML content (such as SVG or MathML). The default value is "html".
+ * #### `templateNamespace`
+ * String representing the document type used by the markup in the template.
+ * AngularJS needs this information as those elements need to be created and cloned
+ * in a special way when they are defined outside their usual containers like `<svg>` and `<math>`.
  *
- * * `html` - All root template nodes are HTML, and don't need to be wrapped. Root nodes may also be
+ * * `html` - All root nodes in the template are HTML. Root nodes may also be
  *   top-level elements such as `<svg>` or `<math>`.
- * * `svg` - The template contains only SVG content, and must be wrapped in an `<svg>` node prior to
- *   processing.
- * * `math` - The template contains only MathML content, and must be wrapped in an `<math>` node prior to
- *   processing.
+ * * `svg` - The root nodes in the template are SVG elements (excluding `<math>`).
+ * * `math` - The root nodes in the template are MathML elements (excluding `<svg>`).
  *
- * If no `type` is specified, then the type is considered to be html.
+ * If no `templateNamespace` is specified, then the namespace is considered to be `html`.
  *
  * #### `template`
  * HTML markup that may:
@@ -1339,7 +1338,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
             if (jqLiteIsTextNode(directiveValue)) {
               $template = [];
             } else {
-              $template = jqLite(wrapTemplate(directive.type, trim(directiveValue)));
+              $template = jqLite(wrapTemplate(directive.templateNamespace, trim(directiveValue)));
             }
             compileNode = $template[0];
 
@@ -1786,7 +1785,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
           templateUrl = (isFunction(origAsyncDirective.templateUrl))
               ? origAsyncDirective.templateUrl($compileNode, tAttrs)
               : origAsyncDirective.templateUrl,
-          type = origAsyncDirective.type;
+          templateNamespace = origAsyncDirective.templateNamespace;
 
       $compileNode.empty();
 
@@ -1800,7 +1799,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
             if (jqLiteIsTextNode(content)) {
               $template = [];
             } else {
-              $template = jqLite(wrapTemplate(type, trim(content)));
+              $template = jqLite(wrapTemplate(templateNamespace, trim(content)));
             }
             compileNode = $template[0];
 

test/ng/compileSpec.js

@@ -839,12 +839,12 @@ describe('$compile', function() {
         }));
 
         if (window.SVGAElement) {
-          it('should support SVG templates using directive.type=svg', function() {
+          it('should support SVG templates using directive.templateNamespace=svg', function() {
             module(function() {
               directive('svgAnchor', valueFn({
                 replace: true,
                 template: '<a xlink:href="{{linkurl}}">{{text}}</a>',
-                type: 'SVG',
+                templateNamespace: 'SVG',
                 scope: {
                   linkurl: '@svgAnchor',
                   text: '@?'
@@ -866,13 +866,13 @@ describe('$compile', function() {
         // and even there, the browser does not export MathML element constructors globally.
         // So the test is slightly limited in what it does. But as browsers begin to
         // implement MathML natively, this can be tightened up to be more meaningful.
-        it('should support MathML templates using directive.type=math', function() {
+        it('should support MathML templates using directive.templateNamespace=math', function() {
           module(function() {
             directive('pow', valueFn({
               replace: true,
               transclude: true,
               template: '<msup><mn>{{pow}}</mn></msup>',
-              type: 'MATH',
+              templateNamespace: 'MATH',
               scope: {
                 pow: '@pow',
               },
@@ -888,6 +888,7 @@ describe('$compile', function() {
             $rootScope.$digest();
             var child = element.children().eq(0);
             expect(nodeName_(child)).toMatch(/msup/i);
+            expect(child[0].constructor).toBe(Element);
           });
         });
       });
@@ -1736,12 +1737,12 @@ describe('$compile', function() {
         }));
 
         if (window.SVGAElement) {
-          it('should support SVG templates using directive.type=svg', function() {
+          it('should support SVG templates using directive.templateNamespace=svg', function() {
             module(function() {
               directive('svgAnchor', valueFn({
                 replace: true,
                 templateUrl: 'template.html',
-                type: 'SVG',
+                templateNamespace: 'SVG',
                 scope: {
                   linkurl: '@svgAnchor',
                   text: '@?'
@@ -1764,13 +1765,13 @@ describe('$compile', function() {
         // and even there, the browser does not export MathML element constructors globally.
         // So the test is slightly limited in what it does. But as browsers begin to
         // implement MathML natively, this can be tightened up to be more meaningful.
-        it('should support MathML templates using directive.type=math', function() {
+        it('should support MathML templates using directive.templateNamespace=math', function() {
           module(function() {
             directive('pow', valueFn({
               replace: true,
               transclude: true,
               templateUrl: 'template.html',
-              type: 'MATH',
+              templateNamespace: 'math',
               scope: {
                 pow: '@pow',
               },
@@ -1787,6 +1788,7 @@ describe('$compile', function() {
             $rootScope.$digest();
             var child = element.children().eq(0);
             expect(nodeName_(child)).toMatch(/msup/i);
+            expect(child[0].constructor).toBe(window.Element);
           });
         });
       });