Normative: specify creation order for capturing group properties #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
needs consensus
ljharb
approved these changes
Feb 27, 2021
michaelficarra
approved these changes
Mar 1, 2021
ljharb
added
has consensus
|
This got consensus today. As there's already tests exercising it, and it matches all shipping implementations, I believe it can be merged. |
bakkot
added
the
ready to merge
ljharb
force-pushed
the
regexp-prop-order
branch
from
e17cc8a to
750b51c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order in which the non-numeric properties are created (i.e. those from named capturing groups) is observable with
Object.keys.This matches all the engines I have on hand. It's only very technically normative, and test262 already tests for this behavior (x, x). Thanks to @jmdyck for pointing this out and linking the tests.