Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ben Feedback #7

Open
9 tasks
pemrouz opened this issue May 24, 2019 · 0 comments
Open
9 tasks

Ben Feedback #7

pemrouz opened this issue May 24, 2019 · 0 comments

Comments

@pemrouz
Copy link
Contributor

pemrouz commented May 24, 2019

Very productive meeting with @benlesh and lots of great feedback.

  • Handling via .then/.catch/.finally - do we need synchronous way to handle these too?
  • Examples for a consumer initiating early termination (emitter.resolve(), emitter.reject())
  • Useful to pre-emptively cover what-if scenarios e.g. tearing down an Emitter generating infinite values
  • There were footguns with operators on prototype, essentially global mutable state. Functional approach is much better, not just stylistic.
  • Eager vs lazy example
  • Subscription/unsubscription is bidrectional in Observables, but values always flow down.
  • Observable-Promise integration via promise-returning forEach was more of a concession, still requires subscription.
  • Iterator design has weird edge cases, e.g. what does .return with a value actually do, handling that can be esoteric, or what does tuple with value and done: true mean, etc. We should document clearly all these interactions (from and reduce take generators/iterators and have some API docs, may benefit from separate docs).
  • Changing shape to be closer to Observable would benefit from users already using that. We'll investigate after June trying to express both as the other to see if we can make adoption smoother.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant