Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Describe Stack Frames using Records #37

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Editorial: Describe Stack Frames using Records #37

wants to merge 3 commits into from

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Feb 17, 2021 •
edited
Loading

It doesn’t make sense to introduce a new specification type that is also an ECMAScript runtime Object value, so this changes it to use Records.

Also fixes #27

Depends on:

This was referenced Feb 17, 2021
Draft
Draft
Open
ljharb
ljharb requested changes Feb 17, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with the OP; but I also don't think it's a good use of time to polish the spec text for this proposal at this time, given that there may still need to be a lot of changes before it's viable.

Base automatically changed from master to main February 17, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"span" may need to be optional
2 participants
@ExE-Boss @ljharb