Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signDisplay with formatRange #13

Closed
sffc opened this issue Apr 29, 2020 · 2 comments
Closed

signDisplay with formatRange #13

sffc opened this issue Apr 29, 2020 · 2 comments
Labels
has-consensus Has consensus and ready to implement

Comments

@sffc
Copy link
Collaborator

sffc commented Apr 29, 2020

What should happen here?

const nf = new Intl.NumberFormat("en", {
  signDisplay: "always"
});

console.log(nf.formatRange(50, 70));
console.log(nf.formatRange(50, 50));

Options:

Description 50 - 70 50 - 50
Always obey signDisplay +50–70 +50
Obey on identity fallback 50–70 +50
Ignore 50–70 50

CLDR does not clearly specify this case.

If we picked the second option (obey only on identity fallback), it would work nicely with #6 and #10, to let you toggle back and forth between the two main options for identityFallback.

@sffc sffc added discuss Needs discussion to make progress design Needs design work to make progress and removed discuss Needs discussion to make progress labels Oct 8, 2020
@sffc
Copy link
Collaborator Author

sffc commented Oct 8, 2020

@sffc
Copy link
Collaborator Author

sffc commented Jan 14, 2021

We should do option 1. This is consistent with the discussion on 2020-10-08.

@sffc sffc added has-consensus Has consensus and ready to implement and removed design Needs design work to make progress labels Jan 14, 2021
@sffc sffc closed this as completed in 8d8e9a6 Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-consensus Has consensus and ready to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant