-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambiguous signature of Observable.subscribe() #168
Comments
The spec is specific about this: foo would get called. |
I believe the section @benjamingr is referring to is |
Maybe it should be like in Promises |
Can someone please propose a concrete use case for monkeypatching a It seems to be such an unlikely case that I don't care which one gets called. Preferring As we've discussed, the current proposal is not ambiguous about how |
It was my mistake, I thought the README was the spec. (Maybe this should be clear in the README too? Or is this too edge-case-y?) I can't think of any concrete use case for why someone would monkeypatch a I also do think there's practical value in being simpler by having only a single signature for one of this proposal's principle APIs. Closing because my original question was answered. |
It's unclear to me from the current spec what the following does:
When the observable publishes an event, what gets logged,
foo:
ornext:
or both or neither?Also, it would be nice if the proposal provided some justification for why both signatures are necessary. Why not, similar to promises, only have the
subscribe(onNext : Function, onError? : Function, onComplete? : Function) : Subscription
signature?The text was updated successfully, but these errors were encountered: