You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Spotted by @anba in #1502, split out into a separate issue.
I believe step 10 of ToTemporalMonthDay should pass result.[[Year]] as the last argument, not referenceISOYear.
Justification: assume ToTemporalMonthDay is called with the string 2023-01-05[u-ca=hebrew] which should give a PlainMonthDay of today's date in the Hebrew calendar, 12 Tevet. After step 7, we get a Record with:
[[Calendar]]: "hebrew"
The early return in step 9 is skipped. Step 10 creates a PlainYearMonth with the ISO reference date of 1972-01-05, which is 18 Tevet, not 12 Tevet. This result is wrong. Instead, the reference date should be 2023-01-05, which gets passed to CalendarMonthDayFromFields in step 11 to canonicalize the reference date to 1971-12-30 (12 Tevet in the reference year.)
The text was updated successfully, but these errors were encountered:
Spotted by @anba in #1502, split out into a separate issue.
I believe step 10 of ToTemporalMonthDay should pass result.[[Year]] as the last argument, not referenceISOYear.
Justification: assume ToTemporalMonthDay is called with the string
2023-01-05[u-ca=hebrew]
which should give a PlainMonthDay of today's date in the Hebrew calendar, 12 Tevet. After step 7, we get a Record with:The early return in step 9 is skipped. Step 10 creates a PlainYearMonth with the ISO reference date of 1972-01-05, which is 18 Tevet, not 12 Tevet. This result is wrong. Instead, the reference date should be 2023-01-05, which gets passed to CalendarMonthDayFromFields in step 11 to canonicalize the reference date to 1971-12-30 (12 Tevet in the reference year.)
The text was updated successfully, but these errors were encountered: