Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar fields can include constructor and __proto__ #2576

Closed
ljharb opened this issue May 15, 2023 · 1 comment
Closed

Calendar fields can include constructor and __proto__ #2576

ljharb opened this issue May 15, 2023 · 1 comment

Comments

@ljharb
Copy link
Member

ljharb commented May 15, 2023

It seems that currently a calendar's fields method can return a list that includes constructor and/or __proto__.

I can't think of any use case where these two properties should be calendar fields. If not, should we ban them? It might avoid a class of prototype pollution vulnerabilities as well.
@ptomato ptomato mentioned this issue May 16, 2023
Merged
@ptomato ptomato mentioned this issue Jul 18, 2023
Closed
@justingrant
Copy link
Collaborator

Meeting 2023-08-17: This was fixed in #2570. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @justingrant