Skip to content
This repository has been archived by the owner on Aug 29, 2021. It is now read-only.

Review "running execution context" handling in AsyncBlockStart #143

Closed
Ms2ger opened this issue Jun 10, 2020 · 4 comments
Closed

Review "running execution context" handling in AsyncBlockStart #143

Ms2ger opened this issue Jun 10, 2020 · 4 comments

Comments

@Ms2ger
Copy link
Collaborator

Ms2ger commented Jun 10, 2020

AsyncBlockStart does

  1. Let runningContext be the running execution context.

so it can use it later in

  1. Assert: When we return here, asyncContext has already been removed from the execution context stack and runningContext is the currently running execution context.

But ExecuteModule does

  1. Suspend the currently running execution context.

before calling AsyncBlockStart. Does AsyncBlockStart end up with the right value?

@codehag
Copy link
Collaborator

codehag commented Apr 6, 2021

This is still a TODO, will get to it this week

@codehag
Copy link
Collaborator

codehag commented May 13, 2021

Closing per #175

@codehag codehag closed this as completed May 13, 2021
@guybedford
Copy link
Collaborator

Reopening this as after further discussion with @codehag we determined that the current specification is self-consistent but doesn't seem to imply that microtasks should be run before asynchronous module evaluations. So this may be a spec oversight that needs more eyes on it.

@guybedford guybedford reopened this May 14, 2021
@codehag
Copy link
Collaborator

codehag commented May 25, 2021

This can now be definitively closed via tc39/ecma262#2409

@codehag codehag closed this as completed May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants