-
Notifications
You must be signed in to change notification settings - Fork 46
Promise in Evaluate() Concrete Method makes no sense #31
Comments
I think the whole evaluation [[Status]] and [[EvaluationError]] should be scrapped in favour of storing the promise as soon as the module is instantiated. |
@bergus agreed storing the promise sounds like the better approach, especially when dealing with overlapping subgraph execution cases as well. |
To add another note here while I've been working on this, the stored promise should be of the current execution only, and not including the dependency executions, so that overlapping top-level circular execution graphs don't have to wait unnecessarily on eachother (where there can be different subtree execution orderings). |
@guybedford Not sure whether we should disallow circles in asynchronously evaluated modules (i.e. with top-level |
@GeorgNeis Yes, I agree that this is a problem. Do you think that guybedford#1 provides a working solution? |
This issue is fixed now that #33 has landed. |
Evaluate now returns a promise, but that promise is disconnected from InnerModuleEvaluation and is always resolved right before returning it.
The text was updated successfully, but these errors were encountered: