Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Editorial: Wording of IsWellFormedUnitIdentifier #21

Closed
littledan opened this issue Oct 30, 2018 · 2 comments
Closed

Editorial: Wording of IsWellFormedUnitIdentifier #21

littledan opened this issue Oct 30, 2018 · 2 comments

Comments

@littledan
Copy link
Member

Steps 1-4 seem to be implied by step 5. They could be deleted (unless we want to go back on our only-this-list-of-units policy).

The strings in Step 5 should be surrounded by backticks and double quotes.
@sffc
Copy link
Collaborator

sffc commented Oct 30, 2018

Let's wait on the resolution to #17 + #19. If those go through, then we will need to have this more advanced parsing logic in IsWellFormedUnitIdentifier in order to check for correctness of custom compound units.

@sffc sffc mentioned this issue Nov 15, 2018
Closed
@sffc
Copy link
Collaborator

sffc commented Nov 23, 2018

I updated the spec with the new "core unit identifiers" syntax last week in 7606464.

@sffc sffc closed this as completed Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@littledan @sffc