Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import attributes tests violate module specifier rules #4406

Closed
linusg opened this issue Feb 20, 2025 · 0 comments · Fixed by #4407
Closed

Import attributes tests violate module specifier rules #4406

linusg opened this issue Feb 20, 2025 · 0 comments · Fixed by #4407

Comments

@linusg
Copy link
Member

linusg commented Feb 20, 2025

$ git grep '\.\./resources'
test/language/module-code/import-attributes/allow-nlt-before-with.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/import-attributes/import-attribute-key-identifiername.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/import-attributes/import-attribute-key-string-double.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/import-attributes/import-attribute-key-string-single.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/import-attributes/import-attribute-many.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/import-attributes/import-attribute-newlines.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/import-attributes/import-attribute-trlng-comma.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/import-attributes/import-attribute-value-string-double.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/import-attributes/import-attribute-value-string-single.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/source-phase-import/import-source-binding-name-2.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/source-phase-import/import-source-binding-name.js:import "../resources/ensure-linking-error_FIXTURE.js";
test/language/module-code/source-phase-import/import-source-newlines.js:import "../resources/ensure-linking-error_FIXTURE.js";

From https://github.com/tc39/test262/blob/main/INTERPRETING.md#modules:

All module specifiers used by Test262 begin with the character sequence ./.

test262-harness throws files into something like /tmp/BMyG8HPwaoqz0jyPNeth/ so the import gets resolved as /tmp/resources/ensure-linking-error_FIXTURE.js which doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant