Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update together (Threepid and Displayname) at each login #2

Open
1 of 2 tasks
odelcroi opened this issue Dec 20, 2024 · 0 comments
Open
1 of 2 tasks

Update together (Threepid and Displayname) at each login #2

odelcroi opened this issue Dec 20, 2024 · 0 comments

Comments

@odelcroi
Copy link
Member

odelcroi commented Dec 20, 2024

Currently, the update of the threepid (email) only works at first proconnect login :

  • if oidc identity is matched to a threepid that differs from email claims, the threepid is updated.

In my opinion, it causes confusion for the user :

  • as the threepid is used for legacy login, after the threepid is updated, the user must use the new threepid for legacy login
  • it is hard to explain that this happens
  • it is hard for the user to remember
  • it is hard for the user to understand that this replacement only happens at the first oidc login

Thus I would recommend to switch off the actuel threepid replacement mecanism and implement another logic :

  • anytime after a oidc login, if oidc identity is matched to a threepid that differs from email claims, the threepid is updated AND the display name is updated too

-> users have a visual feedback that their threepid has been updated thanks to the display name
-> as it happens anytime, it helps understanding

This can be achieved with the synapse option : update_profile_information

Todo :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant