Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

study rebase 1.11.29 #528

Closed
odelcroi opened this issue Apr 11, 2023 · 0 comments
Closed

study rebase 1.11.29 #528

odelcroi opened this issue Apr 11, 2023 · 0 comments
Assignees
Labels
P1 Priority 1 web

Comments

@odelcroi
Copy link
Member

odelcroi commented Apr 11, 2023

Updates:

I did not find PR that would impact our code negatively.

When trying to do a rebase, I also noticed that something was added in .github/workflows/static_analysis.yaml, related to typescript:

    tsc-strict:
        name: Typescript Strict Error Checker
        if: github.event_name == 'pull_request'
        runs-on: ubuntu-latest
        permissions:
            pull-requests: read
            checks: write
        steps:
            - uses: actions/checkout@v3

            - name: Install Deps
              run: "scripts/tchap/install-yarn-linked-repositories.sh"

            - name: Get diff lines
              id: diff
              uses: Equip-Collaboration/diff-line-numbers@df70b4b83e05105c15f20dc6cc61f1463411b2a6 # v1.0.0
              with:
                  include: '["\\.tsx?$"]'

            - name: Detecting files changed
              id: files
              uses: futuratrepadeira/changed-files@96d5fd702a6479d573287ef07381ad59acc390ed # v4.0.0
              with:
                  repo-token: ${{ secrets.GITHUB_TOKEN }}
                  pattern: '^.*\.tsx?$'

            - uses: t3chguy/typescript-check-action@main
              with:
                  repo-token: ${{ secrets.GITHUB_TOKEN }}
                  use-check: false
                  check-fail-mode: added
                  output-behaviour: annotate
                  ts-extra-args: "--strict --noImplicitAny"
                  files-changed: ${{ steps.files.outputs.files_updated }}
                  files-added: ${{ steps.files.outputs.files_created }}
                  files-deleted: ${{ steps.files.outputs.files_deleted }}
                  line-numbers: ${{ steps.diff.outputs.lineNumbers }}
@odelcroi odelcroi added web P1 Priority 1 labels Apr 11, 2023
@aulamber aulamber self-assigned this Apr 25, 2023
@aulamber aulamber closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority 1 web
Projects
None yet
Development

No branches or pull requests

2 participants