Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge-patches script : needs to output a git-moved file after continue #764

Open
estellecomment opened this issue Oct 9, 2023 · 2 comments
Labels

Comments

@estellecomment
Copy link
Contributor

After fixing a conflict in a patch, you run bash ./scripts/tchap/merge-patches.sh continue
It creates the patch file, but you still need to do a lot of moving files around, and making git understand that the patch file has been renamed.

What we want is something like this :

image
@github-actions github-actions bot added the web label Oct 9, 2023
@estellecomment
Copy link
Contributor Author

estellecomment commented Oct 9, 2023

Currently to fix I have to do this :

mv patches/cross-signing-ui/matrix-react-sdk+3.81.0.patch matrix-react-sdk+3.81.0.patch
cp patches/cross-signing-ui/matrix-react-sdk+3.79.0.patch patches/cross-signing-ui/matrix-react-sdk+3.79.0.old.patch
git mv patches/cross-signing-ui/matrix-react-sdk+3.79.0.patch patches/cross-signing-ui/matrix-react-sdk+3.81.0.patch
mv matrix-react-sdk+3.81.0.patch patches/cross-signing-ui/matrix-react-sdk+3.81.0.patch
git add patches/cross-signing-ui/matrix-react-sdk+3.81.0.patch

@estellecomment
Copy link
Contributor Author

started something in #766 , not clean enough yet (crashes as soon as something is unexpected, and some vars are hardcoded)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant