Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a new data table widget #181

Closed
tconbeer opened this issue Aug 21, 2023 · 2 comments · Fixed by #251
Closed

Implement a new data table widget #181

tconbeer opened this issue Aug 21, 2023 · 2 comments · Fixed by #251
Labels
enhancement New feature or request

Comments

@tconbeer
Copy link
Owner

The built-in widget is ok, but its data structures are super inefficient, which limits us to about 10k rows. It shouldn't be too bad(?) to fork the current widget and represent each row as a tuple of its data.
@tconbeer tconbeer added the enhancement New feature or request label Aug 21, 2023
@tconbeer
Copy link
Owner Author

Would also make it easier to support #87
Also #86

@tconbeer tconbeer changed the title Perf: Implement a new data table widget Implement a new data table widget Aug 21, 2023
@tconbeer
Copy link
Owner Author

Arrow would be the perfect backend for this -- should be able to just slice() the arrow table to the rows in the scroll region

@tconbeer tconbeer mentioned this issue Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use fastdatatable for 1000x speedup tconbeer/harlequin
1 participant
@tconbeer