Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --config support NO_COLOR #552

Closed
tconbeer opened this issue May 10, 2024 · 1 comment · Fixed by #678
Closed

Make --config support NO_COLOR #552

tconbeer opened this issue May 10, 2024 · 1 comment · Fixed by #678
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tconbeer
Copy link
Owner

We manually set the styling for questionary... should check NO_COLOR env var first.

See: #549
@tconbeer tconbeer added the bug Something isn't working label May 10, 2024
@vlnn
Copy link

vlnn commented Jun 6, 2024

Actually themes are also working a bit strange while config, e.g. in light themed terminal active/unactive menu items are pretty hard to tell apart.
Iterm:
CleanShot 2024-06-06 at 09 10 54@2x
Terminal.app:
CleanShot 2024-06-06 at 09 11 44@2x

@tconbeer tconbeer added the good first issue Good for newcomers label Jun 24, 2024
@tconbeer tconbeer mentioned this issue Oct 31, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add NO_COLOR support to the config wizard tconbeer/harlequin
2 participants
@tconbeer @vlnn