Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot create links yet #109

Open
tcr opened this issue Jul 17, 2018 · 0 comments
Open

Cannot create links yet #109

tcr opened this issue Jul 17, 2018 · 0 comments
Labels
A-text-editor Area: text editor C-feature-small Category: small feature requiring few changes.

Comments

@tcr
Copy link
Owner

tcr commented Jul 17, 2018

This should be simple to support, because Bold and Italic are already partially supported on the client. The difference here:

  1. The client needs to detect that the Link button was pressed, and intercede by showing a modal dialog asking for a URL.
  2. That modal dialog needs to be designed and implemented.
  3. Then the result needs to be sent to the server (the button pressed by client command can possibly be extended with a string "data" argument) and used as the value for the Style::Link style.
@tcr tcr added C-feature-small Category: small feature requiring few changes. A-text-editor Area: text editor labels Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-text-editor Area: text editor C-feature-small Category: small feature requiring few changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tcr