Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory path instead of file path #10

Closed
latop2604 opened this issue Jan 25, 2022 · 2 comments · Fixed by #11
Closed

Directory path instead of file path #10

latop2604 opened this issue Jan 25, 2022 · 2 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@latop2604
Copy link

Hello, It's me again. In the latest commit you introduce the method ToAbsoluteUri.

Is it on purpose to trim the file name and only keep the directory? From what I read the vertex uri should target the file instead of the directory.
@latop2604 latop2604 changed the title DirectoryPath instead of file path Directory path instead of file path Jan 25, 2022
@tcz717 tcz717 linked a pull request Jan 25, 2022 that will close this issue
Fix #10 document file path #11
Merged
@tcz717 tcz717 added the bug Something isn't working label Jan 25, 2022
@tcz717
Copy link
Owner

tcz717 commented Jan 25, 2022

Oh, I forgot to check the document path when refactoring. Quick fix has been pushed

@latop2604
Copy link
Author

Fixed, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #10 document file path tcz717/LsifDotnet
2 participants
@latop2604 @tcz717