Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent inconsistency in diagram type across layers #51

Open
corybrunson opened this issue Jan 3, 2024 · 1 comment
Open

prevent inconsistency in diagram type across layers #51

corybrunson opened this issue Jan 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@corybrunson
Copy link
Member

A major problem with the diagram parameter is that different values can be applied to different layers, which results in nonsense. Instead, new coordinate system ggproto classes should be used, perhaps CoordFlat and CoordLandscape, which would transform the entire plot.

@corybrunson corybrunson added the bug Something isn't working label Jan 3, 2024
@corybrunson
Copy link
Member Author

This turned out to be a naïve idea! The different diagrams belong to the statistical transformation; a coordinate ggproto would totally reformat the plot.

The problem of consistency in the use of diagram remains, which might be resolved by making it a settable option.

@corybrunson corybrunson changed the title use coordinate system ggproto classes to change layouts of persistence diagrams prevent inconsistency in diagram type across layers Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant