Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sftp write command not create interim directories #82

Open
mojavelinux opened this issue Feb 7, 2018 · 4 comments
Open

sftp write command not create interim directories #82

mojavelinux opened this issue Feb 7, 2018 · 4 comments

Comments

@mojavelinux
Copy link
Contributor

The sftp write command does not create interim missing directories. The dest command, on the other hand, does create them. I think the commands should be consistent, or there should be an option to control this behavior in both cases. Either way, I don't think the two commands should behave differently.

@mojavelinux
Copy link
Contributor Author

I'd be happy to take this one on. I'll also add a test to verify the behavior of sftp write in both scenarios.

@mojavelinux
Copy link
Contributor Author

If we decide to make this an option, we need to agree on the name. Perhaps something as simple as mkdirs: true.

@zensh
Copy link
Collaborator

zensh commented Feb 7, 2018

The dest command work as like as gulp.dest.

The sftp command should work as like as ssh2's sftp command.

@mojavelinux
Copy link
Contributor Author

I see what you're saying. But I don't think the user of this library should have to be aware of the details of how ssh2 works. I could be okay with the current behavior as a default, as long as there is a way to enable making the directories. Having to stop a stream to make directories using a separate call would really disrupt the flow and elegance of the application code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants