metaprogram the rack_test stale check

Author: twalpole

lib/capybara/rack_test/node.rb

@@ -6,7 +6,6 @@ class Capybara::RackTest::Node < Capybara::Driver::Node
   BLOCK_ELEMENTS = %w[p h1 h2 h3 h4 h5 h6 ol ul pre address blockquote dl div fieldset form hr noscript table].freeze
 
   def all_text
-    stale_check
     native.text
           .gsub(/[\u200b\u200e\u200f]/, '')
           .gsub(/[\ \n\f\t\v\u2028\u2029]+/, ' ')
@@ -16,7 +15,6 @@ def all_text
   end
 
   def visible_text
-    stale_check
     displayed_text.gsub(/\ +/, ' ')
                   .gsub(/[\ \n]*\n[\ \n]*/, "\n")
                   .gsub(/\A[[:space:]&&[^\u00a0]]+/, '')
@@ -25,7 +23,6 @@ def visible_text
   end
 
   def [](name)
-    stale_check
     string_node[name]
   end
 
@@ -34,12 +31,10 @@ def style(_styles)
   end
 
   def value
-    stale_check
     string_node.value
   end
 
   def set(value, **options)
-    stale_check
     return if disabled? || readonly?
 
     warn "Options passed to Node#set but the RackTest driver doesn't support any - ignoring" unless options.empty?
@@ -56,15 +51,13 @@ def set(value, **options)
   end
 
   def select_option
-    stale_check
     return if disabled?
 
     deselect_options unless select_node.multiple?
     native['selected'] = 'selected'
   end
 
   def unselect_option
-    stale_check
     raise Capybara::UnselectNotAllowed, 'Cannot unselect option from single select box.' unless select_node.multiple?
 
     native.remove_attribute('selected')
@@ -73,8 +66,6 @@ def unselect_option
   def click(keys = [], **offset)
     raise ArgumentError, 'The RackTest driver does not support click options' unless keys.empty? && offset.empty?
 
-    stale_check
-
     if link?
       follow_link
     elsif submits?
@@ -88,27 +79,22 @@ def click(keys = [], **offset)
   end
 
   def tag_name
-    stale_check
     native.node_name
   end
 
   def visible?
-    stale_check
     string_node.visible?
   end
 
   def checked?
-    stale_check
     string_node.checked?
   end
 
   def selected?
-    stale_check
     string_node.selected?
   end
 
   def disabled?
-    stale_check
     return true if string_node.disabled?
 
     if %w[option optgroup].include? tag_name
@@ -122,20 +108,27 @@ def path
     native.path
   end
 
-  def find_xpath(locator)
-    stale_check
+  def find_xpath(locator, **_hints)
     native.xpath(locator).map { |el| self.class.new(driver, el) }
   end
 
-  def find_css(locator)
-    stale_check
+  def find_css(locator, **_hints)
     native.css(locator, Capybara::RackTest::CSSHandlers.new).map { |el| self.class.new(driver, el) }
   end
 
+  self.public_instance_methods(false).each do |meth_name|
+    alias_method "unchecked_#{meth_name}", meth_name
+    private "unchecked_#{meth_name}"
+    define_method meth_name do |*args|
+      stale_check
+      send("unchecked_#{meth_name}", *args)
+    end
+  end
+
   def ==(other)
     native == other.native
   end
-
+  
 protected
 
   # @api private