-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new GraphQL ppx #117
Comments
I think it's worth mentioning both, and let users choose |
I see that the old ppx is specified explicitly in Does that require people to install the old one if they just want to use the new one? |
I don't think the ppx is used anywhere in the library, I wouldn't be surprised if that option could be safely removed from the bsconfig. That said, I think it makes sense to mention graphql_ppx_re in the README as a first option, maybe something like As things move towards bs-platform 6, it seems like it would be nice to have the support and to guide people towards the more active library. |
@Schmavery is correct, I believe that flag can be safely removed. The only reason it was included was back when I was first prototyping the examples in repo, but we are long past that point. If anyone wants to make a PR to remove it and update the docs, I'll be happy to review – otherwise I can get to it tomorrow! I do think it'd be good to direct folks towards the more actively maintained lib, so if folks are interested in contributing you could also update the in-repo examples! |
The ppx mentioned in the README is not maintained anymore (announcement). It also may not support BuckleScript 6 (source). Please consider using this one instead.
The text was updated successfully, but these errors were encountered: