Skip to content

Commit a1bf982

Browse files
fix: using eeprom.update() instead of eeprom.write() ; saves potential write cycles
1 parent 737f249 commit a1bf982

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

wordclock_esp8266.ino

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -241,17 +241,17 @@ void setup() {
241241
uint8_t storedVersion = EEPROM.read(ADR_EEPROM_VERSION);
242242
if (storedVersion != EEPROM_VERSION_CODE) {
243243
// Set new defaults
244-
EEPROM.write(ADR_EEPROM_VERSION, EEPROM_VERSION_CODE);
245-
EEPROM.write(ADR_NM_START_H, DEFAULT_NM_START_HOUR);
246-
EEPROM.write(ADR_NM_START_M, DEFAULT_NM_START_MIN);
247-
EEPROM.write(ADR_NM_END_H, DEFAULT_NM_END_HOUR);
248-
EEPROM.write(ADR_NM_END_M, DEFAULT_NM_END_MIN);
249-
EEPROM.write(ADR_BRIGHTNESS, DEFAULT_BRIGHTNESS);
244+
EEPROM.update(ADR_EEPROM_VERSION, EEPROM_VERSION_CODE);
245+
EEPROM.update(ADR_NM_START_H, DEFAULT_NM_START_HOUR);
246+
EEPROM.update(ADR_NM_START_M, DEFAULT_NM_START_MIN);
247+
EEPROM.update(ADR_NM_END_H, DEFAULT_NM_END_HOUR);
248+
EEPROM.update(ADR_NM_END_M, DEFAULT_NM_END_MIN);
249+
EEPROM.update(ADR_BRIGHTNESS, DEFAULT_BRIGHTNESS);
250250
setMainColor(DEFAULT_MC_RED, DEFAULT_MC_GREEN, DEFAULT_MC_BLUE);
251-
EEPROM.write(ADR_STATE, st_clock);
252-
EEPROM.write(ADR_NM_ACTIVATED, DEFAULT_NM_ACTIVATED);
253-
EEPROM.write(ADR_COLSHIFTSPEED, DEFAULT_COLSHIFT_SPEED);
254-
EEPROM.write(ADR_COLSHIFTACTIVE, DEFAULT_COLSHIFT_ACTIVE);
251+
EEPROM.update(ADR_STATE, st_clock);
252+
EEPROM.update(ADR_NM_ACTIVATED, DEFAULT_NM_ACTIVATED);
253+
EEPROM.update(ADR_COLSHIFTSPEED, DEFAULT_COLSHIFT_SPEED);
254+
EEPROM.update(ADR_COLSHIFTACTIVE, DEFAULT_COLSHIFT_ACTIVE);
255255
EEPROM.commit();
256256
}
257257

@@ -750,7 +750,7 @@ void stateChange(uint8_t newState, bool persistant){
750750
logger.logString("State change to: " + stateNames[currentState]);
751751
if(persistant){
752752
// save state to EEPROM
753-
EEPROM.write(ADR_STATE, currentState);
753+
EEPROM.update(ADR_STATE, currentState);
754754
EEPROM.commit();
755755
}
756756
}
@@ -881,7 +881,7 @@ void loadCurrentStateFromEEPROM(){
881881
currentState = EEPROM.read(ADR_STATE);
882882
if(currentState >= NUM_STATES){
883883
currentState = st_clock;
884-
EEPROM.write(ADR_STATE, currentState);
884+
EEPROM.update(ADR_STATE, currentState);
885885
EEPROM.commit();
886886
}
887887
}
@@ -990,7 +990,7 @@ void handleCommand() {
990990
logger.logString("nightModeActivated change via Webserver to: " + modestr);
991991
if(modestr == "1") nightModeActivated = true;
992992
else nightModeActivated = false;
993-
EEPROM.write(ADR_NM_ACTIVATED, nightModeActivated);
993+
EEPROM.update(ADR_NM_ACTIVATED, nightModeActivated);
994994
EEPROM.commit();
995995
checkNightmode();
996996
}
@@ -1009,12 +1009,12 @@ void handleCommand() {
10091009
if(nightModeEndMin < 0 || nightModeEndMin > 59) nightModeEndMin = 0;
10101010
if(brightness < 10) brightness = 10;
10111011
if(dynColorShiftSpeed == 0) dynColorShiftSpeed = 1;
1012-
EEPROM.write(ADR_NM_START_H, nightModeStartHour);
1013-
EEPROM.write(ADR_NM_START_M, nightModeStartMin);
1014-
EEPROM.write(ADR_NM_END_H, nightModeEndHour);
1015-
EEPROM.write(ADR_NM_END_M, nightModeEndMin);
1016-
EEPROM.write(ADR_BRIGHTNESS, brightness);
1017-
EEPROM.write(ADR_COLSHIFTSPEED, dynColorShiftSpeed);
1012+
EEPROM.update(ADR_NM_START_H, nightModeStartHour);
1013+
EEPROM.update(ADR_NM_START_M, nightModeStartMin);
1014+
EEPROM.update(ADR_NM_END_H, nightModeEndHour);
1015+
EEPROM.update(ADR_NM_END_M, nightModeEndMin);
1016+
EEPROM.update(ADR_BRIGHTNESS, brightness);
1017+
EEPROM.update(ADR_COLSHIFTSPEED, dynColorShiftSpeed);
10181018
EEPROM.commit();
10191019
logger.logString("Nightmode starts at: " + String(nightModeStartHour) + ":" + String(nightModeStartMin));
10201020
logger.logString("Nightmode ends at: " + String(nightModeEndHour) + ":" + String(nightModeEndMin));
@@ -1111,7 +1111,7 @@ void handleCommand() {
11111111
String str = server.arg(0);
11121112
if(str == "1") dynColorShiftActive = true;
11131113
else dynColorShiftActive = false;
1114-
EEPROM.write(ADR_COLSHIFTACTIVE, dynColorShiftActive);
1114+
EEPROM.update(ADR_COLSHIFTACTIVE, dynColorShiftActive);
11151115
EEPROM.commit();
11161116
}
11171117
server.send(204, "text/plain", "No Content"); // this page doesn't send back content --> 204

0 commit comments

Comments
 (0)