Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clicking outside of fields (MenuField, MultiSelectField, etc) when on Dialog/Drawer #444

Closed
techniq opened this issue Jul 30, 2024 · 2 comments · Fixed by #499
Closed

Comments

@techniq
Copy link
Owner

techniq commented Jul 30, 2024

See example using MenuField within Drawer

CleanShot.2024-07-30.at.12.37.54.mp4

See also discussion regarding MultiSelectField with Dialog

Likely the culprit is the event.stopPropagation() but there is also some coordination with Popover to not break when doing so.

@sergejbog
Copy link

sergejbog commented Oct 20, 2024

Any news about this? I want to hide a popover when someone clicks outside, but it doesn't seem to work inside a Drawer.

@techniq
Copy link
Owner Author

techniq commented Oct 20, 2024

Any news about this? I want to hide a popover when someone clicks outside, but it doesn't seem to work inside a Drawer.

@sergejbog News flash: This just in... fixed in 0.75.3 via #499.

I originally had stopped event propagation to handle some unexpected triggering of nested models (Menu/Dialog/Drawer, etc), but I could not identify any reasons to keep these in the current state.

Please let me know if you spot any regressions, but I did a fair bit of manual validation and couldn't identify anything, and fixes the Menu click outside use case

CleanShot.2024-10-20.at.00.44.34.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants