[Ready to review] bundle primitive binaries #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency to golang and the primitive package can be painful. Especially on CI where some services do not even support Go.
This will bundle primitive binaries with the package before pushing it to npm. It will contain binaries for 64bit windows, linux and osx. Other systems will still be supported except they will have to go the old way with installing go + primitive.
Implementation ideas welcome, the comments in the code should describe how I am planning to do it.
Best,
Benedikt