Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromfile() should either return None or raise an exception, not return False #57

Open
stefanoborini opened this issue Jan 14, 2019 · 0 comments
Open

fromfile() should either return None or raise an exception, not return False #57

stefanoborini opened this issue Jan 14, 2019 · 0 comments

Comments

@stefanoborini
Copy link

It makes little sense to change the return type of fromfile. Either it's an object (or None if it fails) or it raises an Exception if it fails. Returning an object or a boolean if fails is inconsistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefanoborini