Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit fix failed #1303

Closed
SukeshP1995 opened this issue Sep 6, 2021 · 8 comments
Closed

npm audit fix failed #1303

SukeshP1995 opened this issue Sep 6, 2021 · 8 comments

Comments

@SukeshP1995
Copy link

SukeshP1995 commented Sep 6, 2021

after installing using npm install while doing npm audit fix getting the followinf error

Expected behaviour:

Expected to run npm audit fix successfully

Actual behaviour:

npm audit fix failed

Software versions

  • NodeJS: 15.11.0
  • node-mssql: 6.2.3
  • SQL Server: 2017

WhatsApp Image 2021-09-06 at 6 54 50 PM

@ceisele-r
Copy link

Duplicate of #1288.

But I think the issue here is more and more people run into this and it will not go away because
node-mssql depends on adal-node that is archived (https://github.com/AzureAD/azure-activedirectory-library-for-nodejs) and will probably not receive updates to update to the new publish name of xmldom.
Therefore, I guess the better path forward would be to replace the use of adal-node here in node-mssql with @azure/msal-node (as it's stated in the readme of adal-node - but I don't know how complicated it is).

=> Then, as @azure/msal-node does not depend on xmldom, I think the audit warning would be gone for node-mssql.

@dhensby
Copy link
Collaborator

dhensby commented Sep 7, 2021

The issue being reported here is that npm audit fix is not fixing the problem - that sounds like a problem with npm not with this library.

@dhensby dhensby closed this as completed Sep 7, 2021
@SukeshP1995
Copy link
Author

I used same npm version 2 weeks back and the same node-mssql versiob 2 weeks back and it was working fine.

@SukeshP1995
Copy link
Author

same configuration failed unexpectedly. Please, suggest a solution.

@dhensby
Copy link
Collaborator

dhensby commented Sep 7, 2021

The problem is with the tooling, not with the library. I can't provide a solution to npm not working, sorry.

@SukeshP1995
Copy link
Author

what happens if we dont run npm audit --fix?

@dhensby
Copy link
Collaborator

dhensby commented Sep 7, 2021

I'm afraid this isn't a forum for providing support with npm/node - this is simply for reporting bugs with the mssql library.

Sorry I can't provide any more help

@SukeshP1995
Copy link
Author

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants