Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Better IDE Integration #1629

Open
elliot-huffman opened this issue May 3, 2024 · 5 comments
Open

[FEATURE REQUEST] Better IDE Integration #1629

elliot-huffman opened this issue May 3, 2024 · 5 comments

Comments

@elliot-huffman
Copy link
Contributor

elliot-huffman commented May 3, 2024

Is your feature request related to a problem? If so, please give a short summary of the problem and how the feature would resolve it
When coding on the project, the IDE was slowing me down a little because of the project's lack of IDE integration.
Dev containers use deprecated configurations and out of date docker images.
VS Code extension recommendations don't encompass the full capabilities of VS Code when doing dev for TypeScript.
There is a generic password being used for the SA account in the dev container and test docker containers.

Describe the preferred solution
I have created a GitHub workspace file with the configurations centralized.
I have updated the recommended extension list to better match this project's configuration.
I have randomized the password to reduce the bad practice of using non-random passwords for critical infrastructure. This does not change the fact that it is still hard coded, just trying to get better practices in place for everyone to follow.

I have a PR that I created and will submit it after the token credential (#1624) stuff is done because I accidentally made it a fork of the fork instead of the base project. Whoops :-P

I have tested the debug execution command and VS Code is able to pause the debugger inline on the typescript files.

Additional Learning
https://code.visualstudio.com/docs/editor/workspaces

@elliot-huffman
Copy link
Contributor Author

PR live! (rebuilt my branch to not be dependant.)
#1630

@MichaelSun90
Copy link
Contributor

Thanks for putting all the effort to explain the background and make the PRs.

@elliot-huffman
Copy link
Contributor Author

Would I be able to get you to review my pr?

@MichaelSun90
Copy link
Contributor

I have looked into the PR and added some comments. Like I said on the PR side, will still be better to get feedback from @arthurschreiber.

@elliot-huffman
Copy link
Contributor Author

Just added a learning link to the initial post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants