Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In TLS case NTLM is not handled. #338

Closed
fifafu opened this issue Oct 28, 2015 · 2 comments
Closed

In TLS case NTLM is not handled. #338

fifafu opened this issue Oct 28, 2015 · 2 comments

Comments

@fifafu
Copy link

fifafu commented Oct 28, 2015

If you look at this (in connection.js):

SENT_TLSSSLNEGOTIATION: {
    name: 'SentTLSSSLNegotiation',
    events: {
      socketError: function() {
        return this.transitionTo(this.STATE.FINAL);
      },
      connectTimeout: function() {
        return this.transitionTo(this.STATE.FINAL);
      },
      data: function(data) {
        return this.messageIo.tlsHandshakeData(data);
      },
      message: function() {
        if (this.messageIo.tlsNegotiationComplete) {
          this.sendLogin7Packet();
          return this.transitionTo(this.STATE.SENT_LOGIN7_WITH_STANDARD_LOGIN);
        }
      }
    }
  },

Only standard login is handled.

It would be good to handle the encrypted case for NTLM too, maybe like this:

if (this.config.domain) {
          return this.transitionTo(this.STATE.SENT_LOGIN7_WITH_NTLM);
        } else {
          return this.transitionTo(this.STATE.SENT_LOGIN7_WITH_STANDARD_LOGIN);
        }
@arthurschreiber
Copy link
Collaborator

You're right, Encryption and NTLM authentication don't work together, and your patch seems to be correct. Would you mind opening a PR with your patch and accompanying test cases?

@arthurschreiber
Copy link
Collaborator

This was fixed with #367.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants