Change default value for 'arithabort' to ON in v2.0

[tvrprasad]

Based on the recommendation on MSDN page, perhaps we should change the default value for 'arithabort' to 'on' for 2.0 release. It'll be a breaking change. From the MSDN link https://msdn.microsoft.com/en-us/library/ms190306.aspx:
"
The default ARITHABORT setting for SQL Server Management Studio is ON. Client applications setting ARITHABORT to OFF can receive different query plans making it difficult to troubleshoot poorly performing queries. That is, the same query can execute fast in management studio but slow in the application. When troubleshooting queries with Management Studio always match the client ARITHABORT setting.
"

[ariskemper]

#508 I think this don't need to be setled to ON for production environments?. If you want to troubleshoot you could turn it on via options.

[tvrprasad]

From the MSDN page https://msdn.microsoft.com/en-us/library/ms190306.aspx:
"You should always set ARITHABORT to ON in your logon sessions. Setting ARITHABORT to OFF can negatively impact query optimization leading to performance issues."

Seems like ON gives better performance. Is there a downside to making it the default? The client can turn it off via options with your PR.

[ariskemper]

@tvrprasad i havent read that paper before, i was in doubt because is breaking change, now i agree with you that we could make this default ON.

[arthurschreiber]

#1025 adds a deprecation message when opening a new Connection without specifying an explicit value for enableArithAbort. The next major version will then switch from the default being false to the default being true.

[arthurschreiber]

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀