You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TrxFile is a disturbing object since you expect or believe to have a filename, filepath, etc...
I propose to rename this object TrxContainer, TrxHolder, etc....
I am open to any other renaming but I strongly believe that TrxFile is very confusing.
concatenate function is a nice exemple. When you see TrxFile as an input of this function, I believed that I need to put a filename, however, in reality, you need to load it before calling the function.
Hi trx team
TrxFile
is a disturbing object since you expect or believe to have a filename, filepath, etc...I propose to rename this object
TrxContainer
,TrxHolder
, etc....I am open to any other renaming but I strongly believe that TrxFile is very confusing.
concatenate
function is a nice exemple. When you seeTrxFile
as an input of this function, I believed that I need to put a filename, however, in reality, you need to load it before calling the function.Please, let me know what you think @frheault and @arokem
The text was updated successfully, but these errors were encountered: