Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect tests for nonexistent objects #137

Closed
2e0byo opened this issue Sep 3, 2023 · 2 comments
Closed

Incorrect tests for nonexistent objects #137

2e0byo opened this issue Sep 3, 2023 · 2 comments

Comments

@2e0byo
Copy link
Collaborator

2e0byo commented Sep 3, 2023

See e.g.

mopidy-tidal/mopidy_tidal/library.py

Line 395 in 33b41e1

if not artist:

This check is incorrect as tidalapi never returns anything falsy, but does raise an exception if an invalid album is accessed.
@2e0byo
Copy link
Collaborator Author

2e0byo commented Sep 3, 2023

The recent typing work will actually catch these bugs, so that's good

@2e0byo 2e0byo mentioned this issue Sep 3, 2023
Merged
@tehkillerbee
Copy link
Owner

Fixed in #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tehkillerbee @2e0byo