Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails in IE #11

Open
feychou opened this issue Jan 18, 2017 · 2 comments
Open

Fails in IE #11

feychou opened this issue Jan 18, 2017 · 2 comments

Comments

@feychou
Copy link

feychou commented Jan 18, 2017

Since Promise is not polyfilled, the animation won't work on IE (till latest; it works on Edge though).

This will cause all hosting apps that rely on react-state-animation and have no polyfill installed to get the same error on IE.

screen shot 2017-01-18 at 12 16 50

@feychou
Copy link
Author

feychou commented Jan 20, 2017

I am not sure what the best way to go about it is, many libs just have a warning in the README about compatibility and let the hosting application install the polyfills. That may be best practice in terms of bundle size.

Would you accept a PR with a warning in the README and a polyfill installed in the demo?

@tejitak
Copy link
Owner

tejitak commented Jan 20, 2017

Thanks for opening the issue.
I appreciate if you create a PR which contains the README updates and polyfill installation for the demo code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants